Skip to content

Conversation

minael
Copy link
Member

@minael minael commented Sep 18, 2026

Improved the site’s HTML structure and accessibility by using more semantic elements, adding accessible labels and alt text, and improving keyboard-friendly interactions. Also formatted the updated files with Prettier.

Closes #16

@minael minael added this to the P1 milestone Sep 18, 2026
@minael minael requested a review from emmafre September 18, 2026 13:38
@minael minael self-assigned this Sep 18, 2026
@minael minael requested a review from a team as a code owner September 18, 2026 13:38
@emmafre emmafre linked an issue Sep 18, 2026 that may be closed by this pull request
4 tasks
Copy link
Member

@emmafre emmafre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is well structured, but the change of alt text affected some of the tests in CharacterCardSmall.test.tsx. Update these as well so the tests run successfully

@minael
Copy link
Member Author

minael commented Sep 18, 2026

Good catch, the test should work now.

@minael minael requested a review from emmafre September 18, 2026 14:43
Copy link
Member

@emmafre emmafre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works, well done!

@minael minael merged commit 1f29a8d into dev Sep 18, 2026
@minael minael deleted the 16-improve-html-accessibility branch September 18, 2026 15:05
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve HTML accessibility
2 participants